Skip to content

Do docker releases for pushes to release branches #10330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2020

Conversation

zeripath
Copy link
Contributor

Ensure docker releases are updated with pushes to branches

@codecov-io
Copy link

codecov-io commented Feb 18, 2020

Codecov Report

Merging #10330 into master will increase coverage by 0.02%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10330      +/-   ##
==========================================
+ Coverage    43.7%   43.73%   +0.02%     
==========================================
  Files         585      585              
  Lines       81016    81016              
==========================================
+ Hits        35407    35429      +22     
+ Misses      41223    41206      -17     
+ Partials     4386     4381       -5
Impacted Files Coverage Δ
modules/notification/ui/ui.go 70.37% <73.33%> (ø) ⬆️
modules/indexer/stats/db.go 50% <0%> (-9.38%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
services/pull/pull.go 34.23% <0%> (+0.3%) ⬆️
models/gpg_key.go 55.37% <0%> (+0.55%) ⬆️
models/notification.go 65.18% <0%> (+1.89%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.76% <0%> (+1.92%) ⬆️
services/pull/check.go 35.36% <0%> (+2.43%) ⬆️
services/pull/patch.go 62.89% <0%> (+2.51%) ⬆️
services/pull/temp_repo.go 31.62% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5ae2c...c045874. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 18, 2020
@zeripath zeripath added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Feb 18, 2020
@zeripath zeripath added this to the 1.12.0 milestone Feb 18, 2020
@zeripath zeripath added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.11 labels Feb 18, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 18, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 18, 2020
@zeripath zeripath merged commit 69f80fd into go-gitea:master Feb 18, 2020
@zeripath zeripath deleted the docker-releases branch February 18, 2020 10:24
zeripath added a commit to zeripath/gitea that referenced this pull request Feb 18, 2020
@sapk
Copy link
Member

sapk commented Feb 18, 2020

I am not sure that this will work especially for the tag name used and the autotag feature: http://plugins.drone.io/drone-plugins/drone-docker/#autotag

When the event type is push and the target branch is your default branch (e.g. master) the plugin will automatically tag the image as latest. All other event types and branches are ignored.

@sapk
Copy link
Member

sapk commented Feb 18, 2020

Also the manifest is only compatible with tag and latest and will not support release/v1.11 naming.
I also like that tag like 1 and 1.11 means latest tag 1.11.x and not tip of release/v1.11
I would suggest to revert this commit/PR.

zeripath added a commit that referenced this pull request Feb 18, 2020
zeripath added a commit that referenced this pull request Feb 18, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants