Do docker releases for pushes to release branches (#10330) #10333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lauris BH <[email protected]>
zeripath
added
topic/build
|
I am adding the blocked status because I would prefer that we discuss this before in #10330. |
GiteaBot
added
the
lgtm/need 2
sapk
added
status/blocked
6543
approved these changes
Feb 18, 2020
GiteaBot
added
the
lgtm/need 1
|
o sory ... this is blocked |
|
@sapk I don't understand. What will go wrong here? We previously had dockers being made for the heads of our release branches. |
|
Should 1.11 point to release/v1.11 or to latest tag on release/v1.11? That's the problem. |
|
I would have thought that it would point to the latest release/v1.11 not the latest tag. |
|
Can we decide what to do? Does #10330 need reverting? |
|
We should probably vote |
|
Let's discuss it on the revert PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #10330
Co-authored-by: Lauris BH [email protected]