-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Fix bug on migration 111 #12736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug on migration 111 #12736
Conversation
8ef0924
to
df8ebc2
Compare
Interesting pg is declaring a failed transaction on the 1.6.4 migration. |
Codecov Report
@@ Coverage Diff @@
## master #12736 +/- ##
=======================================
Coverage 43.40% 43.41%
=======================================
Files 648 648
Lines 71569 71581 +12
=======================================
+ Hits 31067 31076 +9
- Misses 35472 35479 +7
+ Partials 5030 5026 -4
Continue to review full report at Codecov.
|
A blank transaction will cause failure on postgres. So we have to check update times before commit. |
The
sess.Begin
have to be invoked ifsess.Commit
will be invoked.From https://drone.gitea.io/go-gitea/gitea/29887/2/13