Skip to content

Fix bug of migraition v111 #12738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2020
Merged

Fix bug of migraition v111 #12738

merged 1 commit into from
Sep 6, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 6, 2020

This was missed by #12736

@lunny lunny added the type/bug label Sep 6, 2020
@lafriks lafriks added this to the 1.13.0 milestone Sep 6, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 6, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12738 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12738      +/-   ##
==========================================
- Coverage   43.40%   43.38%   -0.03%     
==========================================
  Files         648      648              
  Lines       71569    71581      +12     
==========================================
- Hits        31067    31057      -10     
- Misses      35472    35492      +20     
- Partials     5030     5032       +2
Impacted Files Coverage Δ
models/migrations/v111.go 0.00% <0.00%> (ø)
modules/indexer/stats/db.go 43.47% <0.00%> (-17.40%) ⬇️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/log/event.go 57.54% <0.00%> (-0.95%) ⬇️
modules/git/repo.go 49.23% <0.00%> (-0.51%) ⬇️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cc4aad...c748425. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 6, 2020
@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Sep 6, 2020
@zeripath zeripath merged commit e8958bf into go-gitea:master Sep 6, 2020
@zeripath
Copy link
Contributor

zeripath commented Sep 6, 2020

Presumably this needs backporting too

@lunny lunny deleted the lunny/fix_bug_111 branch September 6, 2020 11:57
@zeripath
Copy link
Contributor

please send combined backport of this and #12736

@lunny lunny mentioned this pull request Sep 16, 2020
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Sep 16, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-commenter @zeripath @lafriks @GiteaBot