Ensure validation occurs on clone addresses too #14994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#14984 Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
lafriks
approved these changes
Mar 14, 2021
GiteaBot
added
the
lgtm/need 1
noerw
reviewed
Mar 15, 2021
| return nil | ||
| } | ||
|
|
||
| if u.Scheme == "git" && u.Port() != "" && (strings.Contains(remoteURL, "%0d") || strings.Contains(remoteURL, "%0a")) { |
There was a problem hiding this comment.
This seems subtle, might make sense to separate this condition into its own func so it's less likely to occur again that checks for the same thing are implemented differently
There was a problem hiding this comment.
This was in its own function that wasn't being used! The point is to make sure that there really is only place where this is done.
noerw
reviewed
Mar 15, 2021
modules/migrations/migrate_test.go
Outdated
| @@ -16,30 +16,30 @@ func TestMigrateWhiteBlocklist(t *testing.T) { | |||
| setting.Migrations.AllowedDomains = []string{"github.com"} | |||
| assert.NoError(t, Init()) | |||
|
|
|||
| err := isMigrateURLAllowed("https://gitlab.com/gitlab/gitlab.git") | |||
| err := IsMigrateURLAllowed("https://gitlab.com/gitlab/gitlab.git", nil) | |||
There was a problem hiding this comment.
Maybe also add tests for behaviour when doer is set?
noerw
approved these changes
Mar 15, 2021
GiteaBot
added
lgtm/done
|
I'm not sure what's happening on these tests because they work locally... |
|
for me |
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
|
🚀 |
zeripath
added
the
topic/security
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14984
Signed-off-by: Andrew Thornton [email protected]