Skip to content

Fixed wrong migrate url error description #15010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Mar 16, 2021

#14994 introduced a bug which shows the wrong reason in the error message if the migrate url was invalid.

The following error is shown if github.com is a blocked domain.
grafik

This PR synchronises the error generation with routers/api/v1/repo/migrate.go.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 16, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 17, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 17, 2021
@6543 6543 added this to the 1.14.0 milestone Mar 17, 2021
@6543 6543 added the type/bug label Mar 17, 2021
@6543
Copy link
Member

6543 commented Mar 17, 2021

🚀

@6543 6543 merged commit 7019076 into go-gitea:master Mar 17, 2021
@KN4CK3R KN4CK3R deleted the fix-migrate-url-error-description branch March 17, 2021 07:12
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants