suggested locale fixes #226
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle user ssh key input better ssh_key: when user submitted keys had a newline at the end, strings.Split would have created a slice with an empty last element, and the key type check would be incorrect. Perhaps a better way is to look for 'ssh-rsa' or 'ssh-dsa' at the beginning of the string, but this is simple. * ssh_key: correct indentation
* move init functions from routers/install to routers/init * copyright typo
Clean and test are saner being seperate targets
Semi-automatic linting (don't really document things)
This was done semi-programmatically, not really documenting anything
Lint and document manager api
Have the default 'all' rule just build
Lint action.go
|
This PR needs to be rebased. Beside that I'm fine with adding the translations here until we get up some translation system. LGTM |
tboerger
added
the
lgtm/need 1
golint fixed for modules/base
Lint error.go
Lint git_diff.go
Lint issue.go
Golint fixed for models/issue_comment.go
|
Anything I should be careful about moving between gogs and gitea? |
Project unification, updates for contributors guide and github files
Lint models/repo
Lint models/user.go
Merged
|
moved to #298 |
tboerger
added
reviewed/invalid
and removed
modifies/translation
lgtm/done
ethantkoenig
pushed a commit
to ethantkoenig/gitea
that referenced
this pull request
Nov 19, 2017
replace references in gogs from live.door43.org to door43.org Issue-720
delvh
added
issue/not-a-bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(copied from original)
This addresses the Spanish part of #3764 and two instances of non-ascii apostrophes that caught my eye. Also, some untranslated German messages are translated.