Skip to content

suggested locale fixes #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2016
Merged

suggested locale fixes #298

merged 2 commits into from
Nov 29, 2016

Conversation

stroucki
Copy link
Contributor

@stroucki stroucki commented Nov 29, 2016

Copied from pull request #226. Sorry about the mess. Also includes a new spelling fix for Spanish.

@stroucki stroucki mentioned this pull request Nov 29, 2016
@lunny lunny added this to the 1.0.0 milestone Nov 29, 2016
@strk
Copy link
Member

strk commented Nov 29, 2016

LGTM -- @stroucki note that you can git push -f fork prbranch if you need to override a messed up PR :)

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 29, 2016
dashboard.pointer_lookup_times=Pointer Lookup Times
dashboard.memory_allocate_times=Memory Allocate Times
dashboard.memory_free_times=Memory Free Times
dashboard.pointer_lookup_times=Zeigerlookup-Dauern
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dauern still sounds wrong to me as a German

Copy link
Contributor Author

@stroucki stroucki Nov 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am German too, and it is unusual in common language, but Duden says it is used in technical context.

Note that I've not seen where this text is displayed, so if it is only a single value that is displayed, it should definitely be "Dauer".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strk tried but unsuccessful

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a key for a table in the admin ui where you can see the garbage collection interval and so on. So it should be Dauer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the English appears to be incorrect too. I'll change to "Dauer".

@tboerger
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2016
@tboerger tboerger merged commit 6519718 into go-gitea:master Nov 29, 2016
@stroucki stroucki deleted the 20161128locale branch November 30, 2016 03:17
@tboerger
Copy link
Member

@stroucki just for the records, this is how it looks like:

bildschirmfoto 2016-11-30 um 11 38 08

@stroucki stroucki restored the 20161128locale branch November 30, 2016 18:21
@stroucki
Copy link
Contributor Author

Ah damn, then the proper translation should be "Anzahl", since these are counts and not clock times.

@stroucki stroucki mentioned this pull request Nov 30, 2016
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants