Skip to content

Remove jQuery AJAX from repo collaborator mode dropdown #29371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 24, 2024
Merged

Remove jQuery AJAX from repo collaborator mode dropdown #29371

merged 8 commits into from
Feb 24, 2024

Conversation

yardenshoham
Copy link
Member

  • Removed all jQuery AJAX calls and replaced with our fetch wrapper
  • Tested the repo collaborator mode dropdown functionality and it works as before

Demo using fetch instead of jQuery AJAX

action

@yardenshoham
Remove jQuery AJAX from repo collaborator mode dropdown
7c7616b 
- Removed all jQuery AJAX calls and replaced with our fetch wrapper
- Tested the repo collaborator mode dropdown functionality and it works as before

Signed-off-by: Yarden Shoham <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 24, 2024
@yardenshoham yardenshoham added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Feb 24, 2024
delvh
delvh reviewed Feb 24, 2024
View reviewed changes
@yardenshoham
Copy link
Member Author

Last commit seems to break it

@delvh
Copy link
Member

delvh commented Feb 24, 2024

What do you mean?

@yardenshoham
Copy link
Member Author

action

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2024
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 24, 2024
@silverwind silverwind merged commit 15d071f into go-gitea:main Feb 24, 2024
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 24, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 24, 2024
@yardenshoham yardenshoham deleted the repo-settings-jquery-ajax branch February 25, 2024 06:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yardenshoham @delvh @wxiaoguang @silverwind @GiteaBot