Skip to content

Remove jQuery AJAX from repo collaborator mode dropdown #29371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 24, 2024
Merged

Remove jQuery AJAX from repo collaborator mode dropdown #29371

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7c7616b
Remove jQuery AJAX from repo collaborator mode dropdown
yardenshoham Feb 24, 2024
65afae1
Apply suggestions from code review
yardenshoham Feb 24, 2024
d71178c
Merge branch 'main' into repo-settings-jquery-ajax
yardenshoham Feb 24, 2024
f922fd4
Revert "Apply suggestions from code review"
yardenshoham Feb 24, 2024
b932153
Merge branch 'main' into repo-settings-jquery-ajax
GiteaBot Feb 24, 2024
a8df841
Merge branch 'main' into repo-settings-jquery-ajax
GiteaBot Feb 24, 2024
31237aa
Merge branch 'main' into repo-settings-jquery-ajax
GiteaBot Feb 24, 2024
1cd346e
Merge branch 'main' into repo-settings-jquery-ajax
GiteaBot Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions web_src/js/features/repo-settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import $ from 'jquery';
import {minimatch} from 'minimatch';
import {createMonaco} from './codeeditor.js';
import {onInputDebounce, toggleElem} from '../utils/dom.js';
import {POST} from '../modules/fetch.js';

const {appSubUrl, csrfToken} = window.config;

Expand All @@ -11,18 +12,19 @@ export function initRepoSettingsCollaboration() {
const $dropdown = $(e);
const $text = $dropdown.find('> .text');
$dropdown.dropdown({
action(_text, value) {
async action(_text, value) {
const lastValue = $dropdown.attr('data-last-value');
$.post($dropdown.attr('data-url'), {
_csrf: csrfToken,
uid: $dropdown.attr('data-uid'),
mode: value,
}).fail(() => {
try {
$dropdown.attr('data-last-value', value);
$dropdown.dropdown('hide');
const data = new FormData();
data.append('uid', $dropdown.attr('data-uid'));
data.append('mode', value);
await POST($dropdown.attr('data-url'), {data});
} catch {
$text.text('(error)'); // prevent from misleading users when error occurs
$dropdown.attr('data-last-value', lastValue);
});
$dropdown.attr('data-last-value', value);
$dropdown.dropdown('hide');
}
},
onChange(_value, text, _$choice) {
$text.text(text); // update the text when using keyboard navigating
Expand Down