Remove jQuery .attr from the code line range selection
#30077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
- Switched from jQuery `.attr` to plain javascript `getAttribute` and `setAttribute` - Tested the code line range selection and it works as before Signed-off-by: Yarden Shoham <[email protected]>
yardenshoham
force-pushed
the
repo-code-jquery-attr
branch
from
cdb4897 to
e0216cc
Compare
silverwind
reviewed
Mar 25, 2024
Co-authored-by: silverwind <[email protected]>
silverwind
reviewed
Mar 25, 2024
silverwind
approved these changes
Mar 25, 2024
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Mar 25, 2024
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
that referenced
this pull request
Mar 25, 2024
Anonymous are set to ignore as I [couldn't decide](#30077 (comment)). No current violations. Rule docs: https://eslint.style/rules/js/space-before-function-paren
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this pull request
Mar 30, 2024
Anonymous are set to ignore as I [couldn't decide](go-gitea/gitea#30077 (comment)). No current violations. Rule docs: https://eslint.style/rules/js/space-before-function-paren (cherry picked from commit bcb151c220c3fa6003810e436acdda9cc0501e58)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attrto plain javascriptgetAttributeandsetAttribute