fixed incorrect page navigation with up and down arrow on last item of dashboard repos

[metiftikci]

Previously, pressing the down arrow key on the last item of a list would incorrectly load the latest page when not release key. This commit corrects the logic to ensure that the next page is loaded as intended.

After the fix:

[lunny]

Is the screenshot the previous one or updated one?

[metiftikci]

yes its after. before cant see second page but last page if not release the key

[lunny]

I couldn't reproduce it. The old logic does work for me.

[metiftikci]

@wxiaoguang can you please review again, i fixed the up arrow key also.

the problem for up arrow key is, this line works before the fetch repos. repos.count is 0 and it sets the index to 0 again and request for previous page again, so never shows pages between first and last pages

gitea/web_src/js/components/DashboardRepoList.vue

Lines 336 to 338 in 6121552

	if (this.activeIndex === -1 || this.activeIndex > this.repos.length - 1) {
	this.activeIndex = 0;
	}

[wxiaoguang]

Actually it will be quite complex to make the logic completely right here.

For example: this PR fixes some problems, but I think it introduces new problems:

• If a previous "loading" is slow (due to network problems), then clicking a new page won't start the new loading, the user just gets stuck on current page.

[metiftikci]

@wxiaoguang you are right okey i will look for better solution

[metiftikci]

@wxiaoguang looked again but it looks like slow network or stuck in loading state is not a concern

because in loading state we do not show buttons or repos, user can change tab or input search text which is changeReposFilter function and this change does not block this function on loading state