Fix issue label delete incorrect labels webhook payload #34575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
lunny
reviewed
Jun 2, 2025
lunny
approved these changes
Jun 2, 2025
GiteaBot
added
lgtm/need 1
hiifong
approved these changes
Jun 3, 2025
GiteaBot
removed
the
lgtm/need 1
GiteaBot
added
the
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 4, 2025
* giteaofficial/main: Fix issue label delete incorrect labels webhook payload (go-gitea#34575) fixed incorrect page navigation with up and down arrow on last item of dashboard repos (go-gitea#34570) Remove unnecessary duplicate code (go-gitea#34552) Make pull request and issue history more compact (go-gitea#34588)
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jun 4, 2025
Fixes go-gitea#34560 explanation of the bug in the issue setting `issue.isLabelsLoaded = false` before calling `deleteIssueLabel` guarantee we will load the new state of the labels into the issue object before sending it in the webhook.
silverwind
pushed a commit
that referenced
this pull request
Jun 4, 2025
) Backport #34575 by @badhezi Fixes #34560 explanation of the bug in the issue setting `issue.isLabelsLoaded = false` before calling `deleteIssueLabel` guarantee we will load the new state of the labels into the issue object before sending it in the webhook. Co-authored-by: badhezi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34560
explanation of the bug in the issue
setting
issue.isLabelsLoaded = falsebefore callingdeleteIssueLabelguarantee we will load the new state of the labels into the issue object before sending it in the webhook.