Skip to content

Improve integration tests #8276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 25, 2019
Merged

Improve integration tests #8276

merged 4 commits into from
Sep 25, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 24, 2019

This PR tried to make integration tests locally easier and also fix some problem when parallel running different database integrations tests.

@codecov-io
Copy link

codecov-io commented Sep 24, 2019 •
edited
Loading

Codecov Report

Merging #8276 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8276      +/-   ##
==========================================
+ Coverage   41.54%   41.56%   +0.02%     
==========================================
  Files         492      492              
  Lines       65355    65355              
==========================================
+ Hits        27150    27168      +18     
+ Misses      34709    34692      -17     
+ Partials     3496     3495       -1
Impacted Files Coverage Δ
models/repo_list.go 74.14% <0%> (+0.97%) ⬆️
routers/repo/view.go 43.54% <0%> (+1.01%) ⬆️
models/repo_indexer.go 70.15% <0%> (+3.87%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c05b89a...e01e17e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 24, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 24, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 24, 2019
sapk
sapk suggested changes Sep 24, 2019
View reviewed changes
Copy link
Member

@sapk sapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker inspect command are not needed anymore.

sapk
sapk suggested changes Sep 24, 2019
View reviewed changes
Copy link
Member

@sapk sapk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add required step generate-ini-mysql

sapk
sapk suggested changes Sep 24, 2019
View reviewed changes
Copy link
Member

@sapk sapk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed those two lines also ...

@lunny lunny force-pushed the lunny/improve_integration_test branch from 6dce74c to 7230b00 Compare September 25, 2019 00:29
@lunny
Copy link
Member Author

lunny commented Sep 25, 2019 •
edited
Loading

@sapk All done.

@sapk sapk merged commit a8c0240 into go-gitea:master Sep 25, 2019
@lunny lunny deleted the lunny/improve_integration_test branch September 25, 2019 12:13
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@sapk sapk sapk approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-io @lafriks @sapk @guillep2k @GiteaBot