Skip to content

build: update protobuf plugin #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2021
Merged

build: update protobuf plugin #1770

merged 1 commit into from
Apr 13, 2021

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Apr 13, 2021

@Neenu1995 @chingor13 unbreak build

@elharo elharo requested a review from Neenu1995 April 13, 2021 12:25
@elharo elharo requested a review from a team as a code owner April 13, 2021 12:25
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 13, 2021
@Neenu1995 Neenu1995 changed the title fix: update protobuf plugin build: update protobuf plugin Apr 13, 2021
@Neenu1995 Neenu1995 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2de037e into master Apr 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the xolstice branch April 13, 2021 16:44
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 13, 2021
chingor13 pushed a commit that referenced this pull request May 11, 2021
chingor13 added a commit that referenced this pull request May 11, 2021
* feat: configure initial sp version

* build: update protobuf plugin (#1770)

@Neenu1995 @chingor13 unbreak build

Co-authored-by: Elliotte Rusty Harold <[email protected]>
gcf-owl-bot bot added a commit that referenced this pull request Feb 24, 2023
* chore: add proto group prefix

* add test case for generating google maps

* run new tests in ci

* parameterize group id for proto artifacts

* use helper to compute group id of proto artifacts

* verify non cloud library generation

* change artifact name in golden

* restore new client test

* change description

* change description

* add comments to _proto_group_id
Source-Link: googleapis/synthtool@269a915
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:9bf82029163bc06d58f56682afd1893a42ace3e04b0359accb86f79c6ecdc9f9
diegomarquezp pushed a commit that referenced this pull request Feb 27, 2023
* chore: add proto group prefix

* add test case for generating google maps

* run new tests in ci

* parameterize group id for proto artifacts

* use helper to compute group id of proto artifacts

* verify non cloud library generation

* change artifact name in golden

* restore new client test

* change description

* change description

* add comments to _proto_group_id
Source-Link: googleapis/synthtool@269a915
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:9bf82029163bc06d58f56682afd1893a42ace3e04b0359accb86f79c6ecdc9f9

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Emily Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants