Skip to content

test: drop old databases from instance before running integration tests. #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 29, 2022
Merged

test: drop old databases from instance before running integration tests. #1861

merged 8 commits into from
Apr 29, 2022

Conversation

rajatbhatta
Copy link
Contributor

@rajatbhatta rajatbhatta commented Apr 28, 2022 •
edited
Loading

This commit aims to resolve the RESOURCE_EXHAUSTED errors due to
number of databases in an instance reaching the maximum limit.

We delete all the databases of an instance, which are more than 24 hours old, before running the tests.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1832 ☕️

@rajatbhatta
test: drop old databases from instance before running integration tests.
9dc1991 
This commit aims to resolve the RESOURCE_EXHAUSTED errors due to
number of databases in an instance reaching the maximum limit.
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Apr 28, 2022
@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2022
@rajatbhatta rajatbhatta marked this pull request as ready for review April 28, 2022 11:18
@rajatbhatta rajatbhatta requested a review from a team as a code owner April 28, 2022 11:18
@rajatbhatta rajatbhatta requested review from olavloite and ansh0l April 28, 2022 11:19
olavloite
olavloite reviewed Apr 29, 2022
View reviewed changes
olavloite
olavloite approved these changes Apr 29, 2022
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once the linting build error is fixed)

@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 29, 2022
@rajatbhatta rajatbhatta merged commit 2471d91 into googleapis:main Apr 29, 2022
@rajatbhatta rajatbhatta deleted the issue-1832-patch branch April 29, 2022 07:55
This was referenced May 4, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced May 4, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@ansh0l ansh0l Awaiting requested review from ansh0l

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner.it.ITDatabaseAdminTest: testDatabaseOperations failed
3 participants
@rajatbhatta @olavloite @yoshi-kokoro