Skip to content

fix test_parse test #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2018
Merged

fix test_parse test #126

merged 1 commit into from
Feb 23, 2018

Conversation

max-sixty
Copy link
Contributor

I don't think this test was passing for a while?

@codecov-io
Copy link

codecov-io commented Feb 20, 2018

Codecov Report

Merging #126 into master will decrease coverage by 44.76%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #126       +/-   ##
===========================================
- Coverage    75.7%   30.93%   -44.77%     
===========================================
  Files           8        8               
  Lines        1626     1629        +3     
===========================================
- Hits         1231      504      -727     
- Misses        395     1125      +730
Impacted Files Coverage Δ
pandas_gbq/tests/test_gbq.py 26.79% <0%> (-56.86%) ⬇️
pandas_gbq/gbq.py 20.56% <0%> (-55.8%) ⬇️
pandas_gbq/_load.py 62.5% <0%> (-35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99cd849...6799064. Read the comment docs.

@max-sixty
Copy link
Contributor Author

This leaves other broken tests from #125, but at least fixes one

@tswast tswast merged commit 1155958 into googleapis:master Feb 23, 2018
@max-sixty max-sixty deleted the parse-test branch February 23, 2018 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants