Skip to content

Test incorrectly named #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2018
Merged

Test incorrectly named #125

merged 2 commits into from
Feb 23, 2018

Conversation

max-sixty
Copy link
Contributor

I don't think this was running - it wasn't when I ran pytest locally

@max-sixty max-sixty mentioned this pull request Feb 20, 2018
Merged
@tswast tswast changed the base branch from master to unit-tests February 23, 2018 11:09
@tswast
Copy link
Collaborator

tswast commented Feb 23, 2018

Good catch, thanks! For as much time as I've spent in test_gbq.py, I never knew we had unit tests in that file.

Since this will leave the Travis CI tests busted for a while, I've created a new unit-tests branch for us to fix the rest of them before merging this into master.

@tswast tswast merged commit b18aabd into googleapis:unit-tests Feb 23, 2018
@tswast tswast mentioned this pull request Feb 23, 2018
Closed
@max-sixty max-sixty deleted the test-class-not-runnning branch February 23, 2018 14:22
@max-sixty max-sixty mentioned this pull request Mar 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-sixty @tswast