Skip to content

Skip failing test #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 9, 2018
Merged

Conversation

max-sixty
Copy link
Contributor

Explicitly skip this rather than mis-naming it in master, flup from #125

The overall plan to fix it, without breaking all CI in the meantime, still stands

@codecov-io
Copy link

codecov-io commented Mar 3, 2018

Codecov Report

Merging #138 into master will decrease coverage by 45.91%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #138       +/-   ##
===========================================
- Coverage   75.48%   29.57%   -45.92%     
===========================================
  Files           8        8               
  Lines        1534     1535        +1     
===========================================
- Hits         1158      454      -704     
- Misses        376     1081      +705
Impacted Files Coverage Δ
pandas_gbq/tests/test_gbq.py 23.32% <100%> (-61.02%) ⬇️
pandas_gbq/gbq.py 20.56% <0%> (-55.58%) ⬇️
pandas_gbq/_load.py 62.5% <0%> (-35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac22f4...4634d71. Read the comment docs.

@max-sixty max-sixty force-pushed the test-class-not-runnning branch from c32cc33 to 2279a4b Compare March 8, 2018 01:12
@max-sixty
Copy link
Contributor Author

@tswast gentle ping

@tswast
Copy link
Collaborator

tswast commented Mar 9, 2018

Thanks! Should I delete the pydata:unit-tests branch once this goes in?

@tswast tswast merged commit 369959a into googleapis:master Mar 9, 2018
@max-sixty
Copy link
Contributor Author

Yes delete that branch and we'll start fixing the tests on master

@max-sixty max-sixty deleted the test-class-not-runnning branch March 9, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants