Skip to content

fix(cpp1): emit requires clause of variable template #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

JohelEGP
Copy link
Contributor

Resolves #606.

Testing summary:

100% tests passed, 0 tests failed out of 760

Total Test time (real) =  50.09 sec

Acknowledgements:

@hsutter
Copy link
Owner

hsutter commented Aug 31, 2023

Thanks! I'll do this, but as a separate commit to avoid rebasing around a conflict with a change I just made for GCC diagnostics.

@hsutter hsutter closed this Aug 31, 2023
@JohelEGP JohelEGP deleted the variable_template_requires_clause branch August 31, 2023 19:19
@hsutter
Copy link
Owner

hsutter commented Aug 31, 2023

Also I'll add the new test case to the existing test file pure2-requires-clauses.cpp2 which already has tests for types and functions, so adding the test for variables belongs there -- I'm trying to keep tests grouped together by area where it makes sense, instead of having single/narrow test cases.

hsutter added a commit that referenced this pull request Aug 31, 2023
zaucy pushed a commit to zaucy/cppfront that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] _requires-clause_ of variable not emitted
2 participants