Skip to content

fix(cpp1): emit requires clause of variable template #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
v: <T> const T requires std::same_as<T, i32> = 0;

main: () =
static_assert(!std::invocable<decltype(:<T> (_: T) -> std::type_identity_t<decltype(v<T>)> = { return v<T>; }), i16>);
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@

#define CPP2_USE_MODULES Yes

//=== Cpp2 type declarations ====================================================


#include "cpp2util.h"



//=== Cpp2 type definitions and function declarations ===========================

#line 1 "pure2-bugfix-for-variable-template-requires-clause.cpp2"
template<typename T>
CPP2_REQUIRES (std::same_as<T,cpp2::i32>)
#line 1 "pure2-bugfix-for-variable-template-requires-clause.cpp2"
extern T const v;

auto main() -> int;


//=== Cpp2 function definitions =================================================

#line 1 "pure2-bugfix-for-variable-template-requires-clause.cpp2"
template<typename T>
requires (std::same_as<T,cpp2::i32>)
#line 1 "pure2-bugfix-for-variable-template-requires-clause.cpp2"
T const v {0};

auto main() -> int {
static_assert(!(std::invocable<decltype([]<typename T>([[maybe_unused]] T const& param1) -> std::type_identity_t<decltype(v<T>)>{return v<T>; }),cpp2::i16>)); }

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
pure2-bugfix-for-variable-template-requires-clause.cpp2... ok (all Cpp2, passes safety checks)

77 changes: 40 additions & 37 deletions source/cppfront.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5315,6 +5315,44 @@ class cppfront
}
}


auto const emit_requires_clause = [&]() {
if (
n.requires_clause_expression
|| !function_requires_conditions.empty()
)
{
printer.print_extra("\n");
printer.ignore_alignment( true, n.position().colno + 4 );
if (printer.get_phase() == printer.phase1_type_defs_func_decls) {
// Workaround GCC 10 not supporting requires in forward declarations in some cases.
// See commit 5a0d77f8e297902c0b9712c5aafb6208cfa4c139.
printer.print_extra("CPP2_REQUIRES (");
}
else {
printer.print_extra("requires (");
}

if (n.requires_clause_expression) {
emit(*n.requires_clause_expression);
if (!function_requires_conditions.empty()) {
printer.print_extra(" && ");
}
}

if (!function_requires_conditions.empty()) {
printer.print_extra(function_requires_conditions.front());
for (auto it = std::cbegin(function_requires_conditions)+1; it != std::cend(function_requires_conditions); ++it) {
printer.print_extra(" && " + *it);
}
}

printer.print_extra(")");
function_requires_conditions = {};
printer.ignore_alignment( false );
}
};

// Namespace
if (n.is_namespace())
{
Expand Down Expand Up @@ -5624,43 +5662,6 @@ class cppfront
}
}

auto const emit_requires_clause = [&]() {
if (
n.requires_clause_expression
|| !function_requires_conditions.empty()
)
{
printer.print_extra("\n");
printer.ignore_alignment( true, n.position().colno + 4 );
if (printer.get_phase() == printer.phase1_type_defs_func_decls) {
// Workaround GCC 10 not supporting requires in forward declarations in some cases.
// See commit 5a0d77f8e297902c0b9712c5aafb6208cfa4c139.
printer.print_extra("CPP2_REQUIRES (");
}
else {
printer.print_extra("requires (");
}

if (n.requires_clause_expression) {
emit(*n.requires_clause_expression);
if (!function_requires_conditions.empty()) {
printer.print_extra(" && ");
}
}

if (!function_requires_conditions.empty()) {
printer.print_extra(function_requires_conditions.front());
for (auto it = std::cbegin(function_requires_conditions)+1; it != std::cend(function_requires_conditions); ++it) {
printer.print_extra(" && " + *it);
}
}

printer.print_extra(")");
function_requires_conditions = {};
printer.ignore_alignment( false );
}
};

// If we're only emitting declarations, end the function declaration
if (printer.get_phase() == printer.phase1_type_defs_func_decls)
{
Expand Down Expand Up @@ -5834,6 +5835,8 @@ class cppfront
return;
}

emit_requires_clause();

if (
printer.get_phase() != printer.phase2_func_defs
&& n.parent_is_namespace()
Expand Down