[Bot] Update tasks specs #1030
Merged
[Bot] Update tasks specs #1030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuggingFaceInfra
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca and
ngxson
as code owners
coyotte508
approved these changes
Nov 15, 2024
|
This PR has been created as part of #964. Let's not merge for now. |
HuggingFaceInfra
force-pushed
the
update-tasks-specs-automated-pr
branch
from
0553d63 to
3ba1213
Compare
Wauplin
added a commit
that referenced
this pull request
Nov 18, 2024
This PR adds a Github Action to automatically run the `@huggingface/tasks-gen` scripts and open a PR if anything has changed. The workflow is triggered once a day (3am) and can be triggered manually if needed. Here is an example of auto-generated PR: #1030. --- Note: lint issues seems unrelated. But it doesn't seem to happen on main (see [here](https://github.com/huggingface/huggingface.js/actions/workflows/lint.yml?query=branch%3Amain)) so I don't know what's causing it 😕 --------- Co-authored-by: Pauline Bailly-Masson <[email protected]>
HuggingFaceInfra
force-pushed
the
update-tasks-specs-automated-pr
branch
from
3ba1213 to
65c9415
Compare
Wauplin
reviewed
Nov 19, 2024
Comment on lines
21
to
24
| /** | ||
| * A guideline to be used in the chat_template | ||
| */ | ||
| guideline?: string; |
There was a problem hiding this comment.
Not a fan of this argument as it's not used anymore. Best solution would be to remove it from TGI specs (see slack thread). Let's wait without merging this PR for now.
There was a problem hiding this comment.
opened huggingface/text-generation-inference#2762 to remove guideline from TGI API
HuggingFaceInfra
force-pushed
the
update-tasks-specs-automated-pr
branch
from
81d33ba to
fb18fe3
Compare
HuggingFaceInfra
force-pushed
the
update-tasks-specs-automated-pr
branch
from
fb18fe3 to
3f9a70d
Compare
HuggingFaceInfra
force-pushed
the
update-tasks-specs-automated-pr
branch
from
3f9a70d to
592029f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the @huggingface/tasks specs. It has been generated by running:
This PR was automatically created by the Tasks - Update specs workflow.
Make sure the changes are correct before merging.