Trim commit bounds #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
approved these changes
Feb 26, 2025
| where | ||
| Db: Database + DatabaseCommit, | ||
| { | ||
| pub fn apply_eip7251(&mut self) -> Result<Bytes, EVMError<Db::Error>> { |
There was a problem hiding this comment.
I see, so we're relaxing the bounds on the impl by moving DatabaseCommit strictly to the functions where it's needed. This imo makes sense to make and makes trevm easier to instantiate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
+ DatabaseCommitwherever possible. Goal is to make trevm more-useful for simulation that (may or may not) result in modifying the underlying state