feat: cow #93
Merged
feat: cow #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should go in after #94 , will need significant updates |
prestwich
force-pushed
the
prestwich/cow
branch
from
83b73b3 to
2837010
Compare
Evalir
reviewed
Mar 27, 2025
| self.cache.insert_contract(&mut account.info); | ||
|
|
||
| let db_account = self.cache.accounts.entry(address).or_default(); | ||
| db_account.info = account.info; |
There was a problem hiding this comment.
I assume this is safe even in the SelfDestructed case?
There was a problem hiding this comment.
this code is reproduced from revm directly. which reminds me i need to add a note and a copyright notice
Evalir
reviewed
Mar 27, 2025
Evalir
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache-on-write database. Like CacheDb, but only caches via
DatabaseCommit. this prevents cache duplication when wrapping another caching DB likeState