Dep: update revm to 20 #94
Conversation
| @@ -18,18 +18,18 @@ use std::format; | |||
| /// connector. E.g. the connector may contain some `Db` and the resulting Db may | |||
| /// contain `&Db`. This allows for (e.g.) shared caches between DBs on multiple | |||
| /// threads. | |||
| pub trait DbConnect<'a>: Sync { | |||
| pub trait DbConnect: Sync { | |||
There was a problem hiding this comment.
i don't exactly remember why we couldn't elide this lifetime before—what was the reason?
There was a problem hiding this comment.
so that it could appear in the return types of the functions without being a generic lifetime on the function
|
|
||
| /// The result of driving a bundle to completion. | ||
| pub type DriveBundleResult<'a, Ext, Db, T> = | ||
| Result<EvmNeedsTx<'a, Ext, Db>, EvmBundleDriverErrored<'a, Ext, Db, T>>; | ||
| pub type DriveBundleResult<Db, Insp, T> = |
There was a problem hiding this comment.
nvm i now remember why we have it. But does this change usage in any significant way?
There was a problem hiding this comment.
losing the lifetime is good overall, but order of generics is flipped 😮💨
| gas_priority_fee.take(); | ||
| blob_hashes.clear(); | ||
| max_fee_per_blob_gas.take(); | ||
| authorization_list.take(); | ||
| *max_fee_per_blob_gas = 0; |
There was a problem hiding this comment.
so it now must be populated (no longer an option type), but is ignored during tx validation for non-4844 tx types
There was a problem hiding this comment.
so i think any value is permissible
| *value = self.value.unwrap_or_default(); | ||
| *data = self.input.input().cloned().unwrap_or_default(); | ||
| *nonce = self.nonce; | ||
| *nonce = self.nonce.unwrap_or_default(); // TODO: IS THIS CORRECT? |
There was a problem hiding this comment.
hmm i'm not exactly sure this is correct, i need to check
There was a problem hiding this comment.
soooo it's not the same behavior as it used to be, unfortunately. Because nonce-check-disabling is now in cfg rather than tx. but there's nothing else we can do here -_-
There was a problem hiding this comment.
the rpc server already disables nonce checks on call so this should be fine
Co-authored-by: evalir <[email protected]>
😮💨