Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

[GH-223] Add Block specific configuration options using CLI. #228

Merged
merged 2 commits into from
Jul 19, 2019
Merged

[GH-223] Add Block specific configuration options using CLI. #228

merged 2 commits into from
Jul 19, 2019

Conversation

ksaric
Copy link
Contributor

@ksaric ksaric commented Jul 18, 2019

@ksaric ksaric requested review from deepfire and HirotoShioi July 18, 2019 14:35
@ksaric ksaric requested a review from erikd as a code owner July 18, 2019 14:35
@ksaric
Copy link
Contributor Author

ksaric commented Jul 19, 2019

image

Removed the check until the issue is fixed.
First seen here - #221

Must be intermitent failure 😄

deepfire
deepfire approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ksaric ksaric merged commit f713e1c into master Jul 19, 2019
@deepfire deepfire deleted the ksaric/GH-223 branch July 19, 2019 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepfire deepfire deepfire approved these changes

@HirotoShioi HirotoShioi Awaiting requested review from HirotoShioi

@erikd erikd Awaiting requested review from erikd erikd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksaric @deepfire