Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

Add DaedalusIPC nodejs test #221

Merged
merged 3 commits into from
Jul 31, 2019
Merged

Add DaedalusIPC nodejs test #221

merged 3 commits into from
Jul 31, 2019

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Jul 13, 2019

For PR #209. Adds a test case which uses nodejs to launch DaedalusIPC.

rvl added 2 commits July 13, 2019 18:58
@rvl rvl requested a review from ksaric July 13, 2019 09:02
@rvl rvl requested a review from erikd as a code owner July 13, 2019 09:02
@rvl rvl self-assigned this Jul 13, 2019
Copy link
Contributor

@ksaric ksaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other then the Hydra failure https://hydra.iohk.io/build/954641/nixlog/3, looks good to me.

@rvl
Copy link
Contributor Author

rvl commented Jul 15, 2019

I'm not sure why that test might fail like that now... any ideas @cleverca22 ?

@rvl rvl merged commit 9d0e741 into ksaric/GH-208 Jul 31, 2019
@rvl rvl deleted the ksaric/GH-208-test branch July 31, 2019 06:50
ksaric added a commit that referenced this pull request Aug 3, 2019
* [GH-208] Add node-ipc for wallet.

* [GH-208] Fix Nix deps.

* DaedalusIPC clean ups (#213)

* DaedalusIPC: Clean it up a bit

* Add a test program for DaedalusIPC

* Add DaedalusIPC nodejs test (#221)

* tests: Add DaedalusIPC spec

This uses nodejs to run daedalusIPC.

* nix: Update and regenerate
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants