Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

DaedalusIPC clean ups #213

Merged
merged 3 commits into from
Jul 13, 2019
Merged

DaedalusIPC clean ups #213

merged 3 commits into from
Jul 13, 2019

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Jul 5, 2019 •
edited
Loading

For #209.

I would also like to add the javascript test case from cardano-wallet, but am out of time today.

@rvl rvl requested review from erikd and ksaric as code owners July 5, 2019 07:28
@rvl rvl self-assigned this Jul 5, 2019
erikd
erikd approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@erikd erikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ksaric
ksaric approved these changes Jul 5, 2019
View reviewed changes
Copy link
Contributor

@ksaric ksaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like I mentioned, approving.

app/daedalus-ipc.hs
import Cardano.Shell.DaedalusIPC

main :: IO ()
main = fmap readEither <$> getArgs >>= \case
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fmap readEither <$> == readEither <<$>>

src/Cardano/Shell/DaedalusIPC.hs
daedalusIPC tr port = setupNodeChannel >>= \case
Right chan -> do
logInfo tr "Daedalus IPC server starting"
runNodeChannel (pure . msg) action chan >>= \case
Left (NodeChannelFinished err) ->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably can chain this?

@CodiePP
Copy link
Contributor

CodiePP commented Jul 12, 2019

this needs some update to nix files.

@rvl
Copy link
Contributor Author

rvl commented Jul 12, 2019

OK I updated the nix files. Up to you to decide on <<$>> - I don't normally use it.

@rvl rvl merged commit c12e0b0 into ksaric/GH-208 Jul 13, 2019
@rvl rvl deleted the ksaric/GH-208-cleanup branch July 13, 2019 08:57
@rvl rvl mentioned this pull request Jul 14, 2019
Merged
ksaric added a commit that referenced this pull request Aug 3, 2019
@ksaric
[GH-208] Add node-ipc for wallet. (#209)
ba4fb01 
* [GH-208] Add node-ipc for wallet.

* [GH-208] Fix Nix deps.

* DaedalusIPC clean ups (#213)

* DaedalusIPC: Clean it up a bit

* Add a test program for DaedalusIPC

* Add DaedalusIPC nodejs test (#221)

* tests: Add DaedalusIPC spec

This uses nodejs to run daedalusIPC.

* nix: Update and regenerate
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erikd erikd erikd approved these changes

@ksaric ksaric ksaric approved these changes

Assignees

@rvl rvl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rvl @CodiePP @erikd @ksaric