Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

[GH-78] Create the initial launcher version. #84

Merged
merged 4 commits into from
Apr 9, 2019
Merged

Conversation

ksaric
Copy link
Contributor

@ksaric ksaric commented Apr 5, 2019

#78

It turns out that this simple launcher is good enough for now, we have yet to define the configuration.

@ksaric ksaric requested a review from HirotoShioi April 5, 2019 13:32
@ksaric ksaric requested a review from erikd as a code owner April 5, 2019 13:32
@ksaric ksaric added this to the Implement launcher milestone Apr 5, 2019
@HirotoShioi
Copy link
Contributor

I got two exceptions:

  1. When running main, it throws exception saying directory wallet does not exist.
    *** Exception: ./wallet: createProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
  2. When I create directory wallet and run again, I still get exception saying that it does not have permission.
    *** Exception: ./wallet: createProcess: runInteractiveProcess: exec: permission denied (Permission denied)

Copy link
Contributor

@HirotoShioi HirotoShioi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksaric ksaric merged commit 13c155d into develop Apr 9, 2019
@ksaric ksaric deleted the ksaric/GH-78 branch April 9, 2019 06:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants