Skip to content

Fix #1587: the option shell.buildInputs does not exist ... #1598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

yvan-sraka
Copy link
Contributor

@yvan-sraka yvan-sraka commented Aug 18, 2022

@hamishmack wrote:

I think we need to add the following to the module in shell.nix:

@yvan-sraka yvan-sraka requested a review from hamishmack August 18, 2022 07:40
@yvan-sraka yvan-sraka self-assigned this Aug 18, 2022
@yvan-sraka yvan-sraka linked an issue Aug 18, 2022 that may be closed by this pull request
@yvan-sraka
Copy link
Contributor Author

bors try

iohk-bors bot added a commit that referenced this pull request Aug 18, 2022
@deemp
Copy link
Contributor

deemp commented Aug 18, 2022

When I run with shell.nativeBuildInputs = [ ], I get

error: undefined variable 'mkDerivation'

       at /nix/store/4g2cssi2ajkfvpxlq84bjz5rf36vq4yp-source/modules/shell.nix:62:17:

           61|       type = lib.types.unspecified;
           62|       default = mkDerivation.nativeBuildInputs;
             |                 ^
           63|     };

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 18, 2022

@hamishmack wrote:
> I think we need to add the following to the module in [shell.nix](https://github.com/input-output-hk/haskell.nix/blob/master/modules/shell.nix):
>     * From [`pkgs.mkShell`](https://nixos.org/manual/nixpkgs/stable/#sec-pkgs-mkShell)
>       * name
>       * inputsFrom
>       * shellHook
>     * From [`mkDerivation`](https://github.com/NixOS/nixpkgs/blob/c3b5e5344d08274212621f8931c7404d4745d3fc/pkgs/stdenv/generic/make-derivation.nix#L89-L156)
>       * buildInputs
>       * nativeBuildInputs
>       * passthru
@yvan-sraka yvan-sraka force-pushed the 1587-the-option-shellbuildinputs-does-not-exist branch from 10a527c to 639999e Compare August 18, 2022 10:23
@yvan-sraka yvan-sraka marked this pull request as ready for review August 18, 2022 10:24
@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Aug 18, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 18, 2022

@yvan-sraka yvan-sraka changed the title Fix #1587: the option `shell.buildInputs' does not exist ... Fix #1587: the option shell.buildInputs does not exist ... Aug 18, 2022
@hamishmack
Copy link
Collaborator

bors try

iohk-bors bot added a commit that referenced this pull request Aug 18, 2022
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 18, 2022

@yvan-sraka yvan-sraka merged commit bc1de42 into master Aug 18, 2022
@iohk-bors iohk-bors bot deleted the 1587-the-option-shellbuildinputs-does-not-exist branch August 18, 2022 14:07
@michaelpj
Copy link
Collaborator

Could we write a test for this? maybe not worth it

@yvan-sraka
Copy link
Contributor Author

Could we write a test for this? maybe not worth it

Here it is #1601 😄!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The option `shell.buildInputs' does not exist.
4 participants