-
Notifications
You must be signed in to change notification settings - Fork 247
Fix #1587: the option shell.buildInputs
does not exist ...
#1598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yvan-sraka
merged 2 commits into
master
from
1587-the-option-shellbuildinputs-does-not-exist
Aug 18, 2022
Merged
Fix #1587: the option shell.buildInputs
does not exist ...
#1598
yvan-sraka
merged 2 commits into
master
from
1587-the-option-shellbuildinputs-does-not-exist
Aug 18, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors try |
When I run with error: undefined variable 'mkDerivation'
at /nix/store/4g2cssi2ajkfvpxlq84bjz5rf36vq4yp-source/modules/shell.nix:62:17:
61| type = lib.types.unspecified;
62| default = mkDerivation.nativeBuildInputs;
| ^
63| }; |
tryBuild succeeded: |
@hamishmack wrote: > I think we need to add the following to the module in [shell.nix](https://github.com/input-output-hk/haskell.nix/blob/master/modules/shell.nix): > * From [`pkgs.mkShell`](https://nixos.org/manual/nixpkgs/stable/#sec-pkgs-mkShell) > * name > * inputsFrom > * shellHook > * From [`mkDerivation`](https://github.com/NixOS/nixpkgs/blob/c3b5e5344d08274212621f8931c7404d4745d3fc/pkgs/stdenv/generic/make-derivation.nix#L89-L156) > * buildInputs > * nativeBuildInputs > * passthru
10a527c
to
639999e
Compare
bors try |
tryBuild succeeded: |
shell.buildInputs
does not exist ...
bors try |
tryBuild succeeded: |
hamishmack
approved these changes
Aug 18, 2022
Could we write a test for this? maybe not worth it |
Here it is #1601 😄! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hamishmack wrote: