Skip to content

Fix #1600: add end-2-end test to buildkite suite #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2022
Merged

Fix #1600: add end-2-end test to buildkite suite #1601

merged 1 commit into from
Aug 30, 2022

Conversation

yvan-sraka
Copy link
Contributor

Test of hix project initialization and flakes development shell.

@yvan-sraka yvan-sraka requested a review from hamishmack August 18, 2022 12:11
@yvan-sraka yvan-sraka self-assigned this Aug 18, 2022
@yvan-sraka yvan-sraka linked an issue Aug 18, 2022 that may be closed by this pull request
Add Flake Tests #1600
Closed
@yvan-sraka yvan-sraka force-pushed the 1600-add-flake-tests branch from 5c58df9 to f0ceb04 Compare August 18, 2022 12:27
@yvan-sraka
Copy link
Contributor Author

#1598 should fix this test!

@yvan-sraka yvan-sraka force-pushed the 1600-add-flake-tests branch from f0ceb04 to d71f223 Compare August 18, 2022 12:40
hamishmack
hamishmack reviewed Aug 18, 2022
View reviewed changes
@yvan-sraka yvan-sraka mentioned this pull request Aug 18, 2022
Merged
@yvan-sraka yvan-sraka force-pushed the 1600-add-flake-tests branch from d71f223 to 87d9e52 Compare August 18, 2022 14:17
@yvan-sraka yvan-sraka marked this pull request as ready for review August 18, 2022 14:17
@yvan-sraka yvan-sraka force-pushed the 1600-add-flake-tests branch from 87d9e52 to 55f3df7 Compare August 18, 2022 17:34
@hamishmack
Copy link
Collaborator

Using export didn't help. I guess the env variables are already replaced before the commands are run. It might be better to move this into test/test.sh (which is already run by one of the other buildkite steps). That way when we run test/test.sh ghc8107. Perhaps we could also use sed to set compiler-nix-name in the nix/hix.nix file after hix init runs.

@yvan-sraka yvan-sraka force-pushed the 1600-add-flake-tests branch 11 times, most recently from 2234caa to bdf5f5b Compare August 20, 2022 20:47
@yvan-sraka
Copy link
Contributor Author

yvan-sraka commented Aug 22, 2022 •
edited
Loading

The CI is stuck here (for the same reason as #1579) and I don't understand yet why yes | ... don't fix it …

Edit: the command exited with status 141 …

@yvan-sraka yvan-sraka force-pushed the 1600-add-flake-tests branch from bdf5f5b to 90bde60 Compare August 22, 2022 14:57
yvan-sraka added a commit that referenced this pull request Aug 22, 2022
@yvan-sraka
Add a custom nix.conf file for CI tests
578c0e9 
This should unstuck both #1579 and #1601 ...

n.b. This is enable only when `CI` env variable is set, to not bother
normal users in their interactive tests ;)
@yvan-sraka yvan-sraka mentioned this pull request Aug 22, 2022
Merged
yvan-sraka added a commit that referenced this pull request Aug 22, 2022
@yvan-sraka
Add a custom nix.conf file for CI tests
e0d213b 
This should unstuck both #1579 and #1601 ...

n.b. This is enabled only when `CI` env variable is set, to not bother
normal users in their interactive tests ;)
yvan-sraka added a commit that referenced this pull request Aug 22, 2022
@yvan-sraka
Add a custom nix.conf file for CI tests
7ab430d 
This should unstuck both #1579 and #1601 ...

n.b. This is enabled only when `CI` env variable is set, to not bother
normal users in their interactive tests ;)
@yvan-sraka yvan-sraka marked this pull request as draft August 22, 2022 18:14
hamishmack pushed a commit that referenced this pull request Aug 22, 2022
@yvan-sraka
Add a custom nix.conf file for CI tests (#1611)
3b5d165 
This should unstuck both #1579 and #1601 ...

n.b. This is enabled only when `CI` env variable is set, to not bother
normal users in their interactive tests ;)
@yvan-sraka yvan-sraka force-pushed the 1600-add-flake-tests branch from 90bde60 to 58c43a1 Compare August 26, 2022 09:40
@yvan-sraka yvan-sraka marked this pull request as ready for review August 26, 2022 09:40
@yvan-sraka
Copy link
Contributor Author

bors try

iohk-bors bot added a commit that referenced this pull request Aug 26, 2022
@iohk-bors
Try #1601:
2849b03
@hamishmack hamishmack mentioned this pull request Aug 26, 2022
Merged
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 26, 2022

try

Timed out.

@yvan-sraka yvan-sraka force-pushed the 1600-add-flake-tests branch 2 times, most recently from 3209a32 to e88ddf6 Compare August 29, 2022 09:18
@yvan-sraka yvan-sraka mentioned this pull request Aug 29, 2022
Merged
@yvan-sraka
Copy link
Contributor Author

yvan-sraka commented Aug 29, 2022 •
edited
Loading

Should be rebased on top of #1625 and #1626!

@yvan-sraka yvan-sraka force-pushed the 1600-add-flake-tests branch from e88ddf6 to ac42527 Compare August 29, 2022 11:36
@yvan-sraka yvan-sraka marked this pull request as draft August 29, 2022 14:38
@yvan-sraka yvan-sraka force-pushed the 1600-add-flake-tests branch from ac42527 to dd8388e Compare August 30, 2022 06:28
@yvan-sraka yvan-sraka marked this pull request as ready for review August 30, 2022 06:33
@yvan-sraka yvan-sraka force-pushed the 1600-add-flake-tests branch 5 times, most recently from 081f32d to 5cd15f0 Compare August 30, 2022 07:18
@yvan-sraka yvan-sraka force-pushed the 1600-add-flake-tests branch from 5cd15f0 to c76f8eb Compare August 30, 2022 07:35
@yvan-sraka yvan-sraka requested a review from hamishmack August 30, 2022 08:19
@hamishmack hamishmack merged commit cc8f2c6 into master Aug 30, 2022
@iohk-bors iohk-bors bot deleted the 1600-add-flake-tests branch August 30, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishmack hamishmack Awaiting requested review from hamishmack

Assignees

@yvan-sraka yvan-sraka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Flake Tests
2 participants
@yvan-sraka @hamishmack