Print warning when kernel argument has multiple buffer_location attributes #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherry-yuan
reviewed
Apr 22, 2022
…butes The auto-discovery string parsing of per kernel argument buffer_location intended to concatenate multiple attributes into a space-separated string, but in fact only retains the value of the last buffer_location attribute since read_string_counters() does not append but assign the string value. Since multiple buffer_location attributes are not supported, print a warning message, and select the last buffer_location attribute such that the functional behaviour of buffer_location parsing remains unchanged. Signed-off-by: Peter Colberg <[email protected]>
zibaiwan
approved these changes
Apr 22, 2022
pcolberg
added a commit
that referenced
this pull request
Apr 29, 2022
This amends #109 Signed-off-by: Peter Colberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auto-discovery string parsing of per kernel argument buffer_location
intended to concatenate multiple attributes into a space-separated string,
but in fact only retains the value of the last buffer_location attribute
since read_string_counters() does not append but assign the string value.
Since multiple buffer_location attributes are not supported, print a
warning message, and select the last buffer_location attribute such that
the functional behaviour of buffer_location parsing remains unchanged.
This is a prerequisite of #108 and #103, since the current implementation
incorrectly checks argument index
jinstead of attribute indexkwhichresults in a build failure when factoring out kernel argument parsing into
a separate function.