-
Notifications
You must be signed in to change notification settings - Fork 70
Support streaming kernel arguments and streaming kernel control #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Each context maintains a pool of manually allocated invocation_wrapper objects, which so far contained only POD types. To support the use of non-POD types, e.g., std::vector, explicitly invoke the constructor using placement new after malloc, and the destructor before free. https://en.cppreference.com/w/cpp/language/new#Placement_new #103 (comment) Signed-off-by: Peter Colberg <[email protected]>
@anandhv I have modified |
Klocwork is failing to correctly analyze use of fpga-runtime-for-opencl/src/acl_kernel_if.cpp Lines 1349 to 1355 in 35adcb6
This may be worked around using, e.g., fpga-runtime-for-opencl/src/acl_kernel_if.cpp Lines 1349 to 1355 in 72c1b68
|
@anandhv Please see the slightly revised HAL MMD streaming kernel API. |
This PR still requires a slight modification to revert the auto-discovery string format back to the initial design, after which it will be ready for integration testing. |
Use valid value 0 for number of fields in streaming kernel info. Signed-off-by: Peter Colberg <[email protected]>
Use valid value 0 for is_sycl_compile field in kernel section. Signed-off-by: Peter Colberg <[email protected]>
Use valid value 0 for number of fields in streaming kernel argument info. Signed-off-by: Peter Colberg <[email protected]>
This parses new fields from the kernel section for streaming kernel control and from the kernel argument section for streaming kernels arguments, both for simulation of IP authoring components. The kernel section is augmented with a boolean field that specifies whether the kernel uses streaming control, i.e., whether the kernel is started using the streaming control start signal and queried for completion using the streaming control done signal via the simulator. The kernel argument section is augmented with a boolean field that specifies whether the kernel argument is a streaming argument, i.e., whether the argument is excluded from the kernel invocation image and directly streamed to the component via the simulator. If the kernel argument is streaming, a string field is added containing the full kernel argument name for the simulator. Signed-off-by: Peter Colberg <[email protected]>
This introduces a backwards-incompatible change in the HAL MMD API between runtime and simulator. Signed-off-by: Peter Colberg <[email protected]>
Signed-off-by: Peter Colberg <[email protected]>
Signed-off-by: Peter Colberg <[email protected]>
Signed-off-by: Peter Colberg <[email protected]>
Signed-off-by: Peter Colberg <[email protected]>
Signed-off-by: Peter Colberg <[email protected]>
Signed-off-by: Peter Colberg <[email protected]>
Signed-off-by: Peter Colberg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
For the case of streaming control kernels in IP authoring, when passing the start and done signals to the simulator MMD, instead of the kernel interface name, pass the full signal names from the auto-discovery string. Before this change, the runtime would pass the kernel name, e.g., `_ZTSZ4mainE4MyIP` without the prefix including the kernel index in case of multiple kernels. After this change, the runtime passes the full signal names, e.g., `k0_ZTSZ4mainE4MyIP_streaming_start` including the kernel index prefix and the streaming control signal suffix. This amends #103 Signed-off-by: Peter Colberg <[email protected]>
For the case of streaming control kernels in IP authoring, when passing the start and done signals to the simulator MMD, instead of the kernel interface name, pass the full signal names from the auto-discovery string. Before this change, the runtime would pass the kernel name, e.g., `_ZTSZ4mainE4MyIP` without the prefix including the kernel index in case of multiple kernels. After this change, the runtime passes the full signal names, e.g., `k0_ZTSZ4mainE4MyIP_streaming_start` including the kernel index prefix and the streaming control signal suffix. This amends intel#103 Signed-off-by: Peter Colberg <[email protected]>
This resolves a failure to pass local-memory sizes and global-memory buffers as streaming arguments to a streaming kernel in simulation. This amends #103 Signed-off-by: Peter Colberg <[email protected]>
This resolves a failure to pass local-memory sizes and global-memory buffers as streaming arguments to a streaming kernel in simulation. This amends #103 Signed-off-by: Peter Colberg <[email protected]> (cherry picked from commit 8336122)
This introduces a backwards-incompatible change in the HAL MMD API between runtime and simulator. The first commit defines the streaming kernel argument interface, while subsequent commits will contain the implementation.
@anandhv @bsyrowik @zibaiwan @sherry-yuan @intel-jisheng1