Pass streaming control signal names to simulator #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Colberg <[email protected]>
For the case of streaming control kernels in IP authoring, when passing the start and done signals to the simulator MMD, instead of the kernel interface name, pass the full signal names from the auto-discovery string. Before this change, the runtime would pass the kernel name, e.g., `_ZTSZ4mainE4MyIP` without the prefix including the kernel index in case of multiple kernels. After this change, the runtime passes the full signal names, e.g., `k0_ZTSZ4mainE4MyIP_streaming_start` including the kernel index prefix and the streaming control signal suffix. This amends #103 Signed-off-by: Peter Colberg <[email protected]>
sophimao
approved these changes
Jul 6, 2022
pcolberg
added a commit
that referenced
this pull request
Jul 6, 2022
This amends #145 Signed-off-by: Peter Colberg <[email protected]>
ericxu233
pushed a commit
to ericxu233/fpga-runtime-for-opencl
that referenced
this pull request
Jul 14, 2022
This amends intel#145 Signed-off-by: Peter Colberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the case of streaming control kernels in IP authoring, when passing
the start and done signals to the simulator MMD, instead of the kernel
interface name, pass the full signal names from the auto-discovery
string. Before this change, the runtime would pass the kernel name,
e.g.,
_ZTSZ4mainE4MyIPwithout the prefix including the kernel indexin case of multiple kernels. After this change, the runtime passes the
full signal names, e.g.,
k0_ZTSZ4mainE4MyIP_streaming_startincludingthe kernel index prefix and the streaming control signal suffix.
This amends #103
Cc: @anandhv