Make auto-discovery error message handling more failsafe #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stringstream err_ss is only used within the function, and the contents must be assigned to err_str which is returned to the caller. This amends #100 Signed-off-by: Peter Colberg <[email protected]>
Currently it is too easy to fill the stringstream err_ss with an error message but forget to assign the contents to the string err_str. Reduce scope of stringstream err_ss to where it is used to make such mistakes more obvious. In C++20, this may be replaced with std::format(). Signed-off-by: Peter Colberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is too easy to fill the stringstream err_ss with an error
message but forget to assign the contents to the string err_str.
Reduce scope of stringstream err_ss to where it is used to make such
mistakes more obvious. In C++20, this may be replaced with std::format().
This is a prerequisite of #108 and #103.