demo: do not pip install ninja

[mythi]

ninja-build is installed as a dependency to meson so we don't need to install it separately. In fact pip install fails on setups that enforce PEP-668 of externally managed environments.

Signed-off-by: Mikko Ylinen [email protected]

[codecov-commenter]

Codecov Report

Merging #1331 (2e5c19c) into main (689c6ab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1331   +/-   ##
=======================================
  Coverage   51.17%   51.17%           
=======================================
  Files          44       44           
  Lines        4879     4879           
=======================================
  Hits         2497     2497           
  Misses       2239     2239           
  Partials      143      143           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[eero-t]

If you're explicitly using ninja in later steps, IMHO would have been better to include ninja to package list. You might also consider --no-install-recommends, and listing needed extra packages explicitly.

[mythi]

If you're explicitly using ninja in later steps, IMHO would have been better to include ninja to package list. You might also consider --no-install-recommends, and listing needed extra packages explicitly.

true. currently ninja-build is a Depends dependency so --no-install-recommends can be enabled independently but you're right that adding it to be explicit makes sense

[mythi]

@eero-t updated as part of #1332