Skip to content

images: move to Debian packaged accel-config #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Feb 13, 2023

Signed-off-by: Mikko Ylinen [email protected]

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #1332 (e380a79) into main (f559d87) will not change coverage.
The diff coverage is n/a.

❗ Current head e380a79 differs from pull request most recent head 339d898. Consider uploading reports for the commit 339d898 to get more accurate results

@@           Coverage Diff           @@
##             main    #1332   +/-   ##
=======================================
  Coverage   51.24%   51.24%           
=======================================
  Files          44       44           
  Lines        4879     4879           
=======================================
  Hits         2500     2500           
  Misses       2237     2237           
  Partials      142      142           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eero-t
Copy link
Contributor

eero-t commented Feb 13, 2023

Looks OK, but tests fail:

   wait for pod "iaa-accel-config-demo" to succeed
  Expected success, but got an error:
      <*fmt.wrapError | 0xc000447d80>: {
          msg: "error while waiting for pod iaaplugin-8081/iaa-accel-config-demo to be Succeeded or Failed: pod \"iaa-accel-config-demo\" failed with reason: \"\", message: \"\"",
          err: <*errors.errorString | 0xc000682f00>{
              s: "pod \"iaa-accel-config-demo\" failed with reason: \"\", message: \"\"",
          },
      }
      error while waiting for pod iaaplugin-8081/iaa-accel-config-demo to be Succeeded or Failed: pod "iaa-accel-config-demo" failed with reason: "", message: ""
  In [It] at: /root/workspace/vendor/k8s.io/kubernetes/test/e2e/framework/pod/pod_client.go:240

  There were additional failures detected after the initial failure:
    [PANICKED]
    Test Panicked
    In [DeferCleanup (Each)] at: /usr/local/go/src/runtime/panic.go:260

    runtime error: invalid memory address or nil pointer dereference

Note: same version of accel-config is also in Debian testing, there's no need to move from Ubuntu to unstable: https://packages.debian.org/bookworm/accel-config

@mythi
Copy link
Contributor Author

mythi commented Feb 13, 2023

Looks OK, but tests fail:

yeah, they fail because I'm dropping that idxd-reset.patch. Looks like we still need it so we'll keep accel-config-demo as is for now.

@mythi mythi marked this pull request as ready for review February 14, 2023 07:02
@mythi
Copy link
Contributor Author

mythi commented Feb 16, 2023

@eero-t looks OK?

@eero-t
Copy link
Contributor

eero-t commented Feb 16, 2023

@mythi Looks OK.

PS. I would have used testing instead of unstable though, because unstable is known to be occasionally broken, but that belongs to some other PR.

Copy link
Contributor

@tkatila tkatila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tkatila tkatila merged commit 340babb into intel:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants