[SYCL][ESIMD][EMU] LSC support bringup #1018
Conversation
|
The fact that this PR passed means that the tests were not actually run, as they could not yet pass on the emulator.
|
|
@pvchupin , would you check if ESIMD_EMULATOR backend is tested during Check-in tests for intel/llvm-test-suite? It looks like not. |
|
/verify with intel/llvm#6099 |
|
I don't think it's tested. Not sure if we have capacity to extend testing now. |
I think I had an e-mail conversation with @vladimirlaz for this issue before. I'll forward you the message if I find it. |
- lsc_usm_atomic_cachehint.cpp is excluded as kernel_bundle() is not supported under ESIMD_EMULATOR
|
LSC-Atomic support for ESIMD_EMULATOR is under review : intel/llvm#6588 |
Can such testing be run by request? Something line (/verify with emulator)? |
|
Unrelated failure Jenkins/pre-ci-logs |
There was a problem hiding this comment.
LGTM. Good to see so many tests are enabled for the emulator.
But, to be on the safe side, please retest with the latest compiler, as I merged intel/llvm#6629 which modifies lsc atomics.
The test passes with sycl branch of intel/llvm containing the change set from PR#6629. |
* Adding 'esimd_emulator' feature for LSC tests * XFAIL marking for unsupported lsc-atomic tests * Enabling LSC-Atomic tests - lsc_usm_atomic_cachehint.cpp is excluded as kernel_bundle() is not supported under ESIMD_EMULATOR
* Adding 'esimd_emulator' feature for LSC tests * XFAIL marking for unsupported lsc-atomic tests * Enabling LSC-Atomic tests - lsc_usm_atomic_cachehint.cpp is excluded as kernel_bundle() is not supported under ESIMD_EMULATOR
No description provided.