[ESIMD] Introduce atomic_update<native::lsc::fadd>(...) and similar ops. #6629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbobrovs
force-pushed
the
lsc_fp_atomics
branch
from
ec6ce71 to
c6e1ba2
Compare
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
kbobrovs
force-pushed
the
lsc_fp_atomics
branch
from
c6e1ba2 to
92c00d5
Compare
v-klochkov
reviewed
Aug 25, 2022
There was a problem hiding this comment.
Looks good.
Most of my comments are minor and could be fixed in a separate change,
but there are 2 comments related to naming of the atomic ops that are created in non-experimental namespace and may need sooner resolution to not pollute non-experimental namespace with something to be changed later/soon.
sycl/include/sycl/ext/intel/experimental/esimd/detail/math_intrin.hpp
Outdated
Show resolved
Hide resolved
… detail/memory_intrin.hpp
v-klochkov
approved these changes
Aug 26, 2022
v-klochkov
reviewed
Aug 26, 2022
| @@ -357,14 +356,14 @@ std::enable_if_t<is_clang_vector_type_v<To> && is_clang_vector_type_v<From>, To> | |||
| template <typename U> constexpr bool is_type() { return false; } | |||
There was a problem hiding this comment.
BTW, we have type checker with exactly same definition, but a better name:
https://github.com/intel/llvm/blob/sycl/sycl/include/sycl/ext/intel/experimental/esimd/detail/util.hpp#L32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sycl::ext::intel::esimd::native::lsc::atomic_opesimd::atomic_updateis invoked withesimd::native::lsc::atomic_op(rather thanesimd::atomic_op), then implementation is redirected to Xe-specific LSC-based implementation (won't run until Gen12)esimd::atomic_opcause warning and are replaced with corresponding LSC operations.Complementary E2E test: intel/llvm-test-suite#1171
Signed-off-by: Konstantin S Bobrovsky [email protected]