This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add <iostream> headers to tests which assumed "CL/sycl.hpp" would have it included #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…would have it included Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
|
/verify with intel/llvm#6337 |
|
/verify with intel/llvm#6337 |
Signed-off-by: Rauf, Rana <[email protected]>
|
/verify with intel/llvm#6337 |
aelovikov-intel
previously approved these changes
Jul 21, 2022
raaiq1
dismissed stale reviews from aelovikov-intel and cperkinsintel
via
62f7f13
Signed-off-by: Rauf, Rana <[email protected]>
|
/verify with intel/llvm#6469 |
raaiq1
changed the title
Need to update PR and the header ( |
aelovikov-intel
previously approved these changes
Jul 28, 2022
|
The changes are good. Please update the first comment so that resulting commit message is accurate. |
|
@intel/llvm-gatekeepers slight ping to merge commit. Thanks |
againull
previously approved these changes
Jul 29, 2022
v-klochkov
previously approved these changes
Jul 29, 2022
pvchupin
dismissed stale reviews from v-klochkov, asudarsa, againull, and aelovikov-intel
via
5a6bbb7
|
I had to make some trivial conflict resolutions due to cl::sycl -> sycl namespace change done earlier |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…uld have it included (intel#1084) The purpose of this PR is support the changes made in PR intel/llvm#6469 , which gets rid of #include <iostream> from sycl headers and is assumed to be included in the "sycl/sycl.hpp" header for some of the tests present in this repository
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…uld have it included (intel/llvm-test-suite#1084) The purpose of this PR is support the changes made in PR intel#6469 , which gets rid of #include <iostream> from sycl headers and is assumed to be included in the "sycl/sycl.hpp" header for some of the tests present in this repository
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is support the changes made in PR intel/llvm#6469 , which gets rid of
#include <iostream>from sycl headers and is assumed to be included in the "sycl/sycl.hpp" header for some of the tests present in this repository