-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL] Remove <iostream> from header and source files #6469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[SYCL][ABI-break] Remove kernel::get_work_group_info (intel#6414)
Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
Can you please add the following tests:
|
I'm sorry, I don't understand what you mean by 'compile cleanly' |
That |
Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
Signed-off-by: Rauf, Rana <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
failing CUDA test is known to be flaky. ( #8800 ) |
Signed-off-by: Rauf, Rana <[email protected]>
@intel/llvm-gatekeepers slight ping to merge commit. Thanks |
…uld have it included (#1084) The purpose of this PR is support the changes made in PR intel/llvm#6469 , which gets rid of #include <iostream> from sycl headers and is assumed to be included in the "sycl/sycl.hpp" header for some of the tests present in this repository
@raaiq1, please follow up on windows post commit issue: https://github.com/intel/llvm/runs/7587694915?check_suite_focus=true |
Just a workaround in sycl/test/regression/fsycl-host-compiler-win.cpp while the proper fix is being investigated/prepared.
…ostream> (#6786) This is to complement this [PR](#6469) which removes \<iostream\> headers to comply with LLVM Coding Standards. Signed-off-by: Rauf, Rana <[email protected]> Signed-off-by: Rauf, Rana <[email protected]>
…uld have it included (intel#1084) The purpose of this PR is support the changes made in PR intel#6469 , which gets rid of #include <iostream> from sycl headers and is assumed to be included in the "sycl/sycl.hpp" header for some of the tests present in this repository
…uld have it included (intel/llvm-test-suite#1084) The purpose of this PR is support the changes made in PR intel#6469 , which gets rid of #include <iostream> from sycl headers and is assumed to be included in the "sycl/sycl.hpp" header for some of the tests present in this repository
-Removed <iostream> headers from header and source files to best conform to LLVM Coding Standards : https://llvm.org/docs/CodingStandards.html#include-iostream-is-forbidden .
-Substituted the removed headers with a proxy header which uses external linkage to resolve symbols in <iostream>