[DO NOT MERGE][DO NOT REVIEW] Specialization constant #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for OpSpecConstantTrue, OpSpecConstantFalse, OpSpecConstant and OpSpecConstantComposite instructions. Add -spec-const command line option which allows to overwrite the default values of specialization constants while translating SPIRV to LLVM. Add getSpecConstInfo API. This API returns specialization sonstant IDs available in the SPIR-V module and their size. This information also can be printed out with -spec-const-info command line option. Signed-off-by: Alexey Sotkin <[email protected]>
Translate SPIRV-friendly LLVM IR builtins represnting specialization constants `__spirv_SpecConstant` to corresponding SPIR-V instructions. This approach works only for scalar constants, so support for `OpSpecConstantComposite` and `OpSpecConstantOp` is not implemented in this patch. Signed-off-by: Alexey Sotkin <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
…uld have it included (intel#1084) The purpose of this PR is support the changes made in PR intel#6469 , which gets rid of #include <iostream> from sycl headers and is assumed to be included in the "sycl/sycl.hpp" header for some of the tests present in this repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cherry-pick of specialization constant patches from https://github.com/KhronosGroup/SPIRV-LLVM-Translator