Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Fix events caching test #1138

Merged
merged 2 commits into from
Sep 14, 2022
Merged

[SYCL] Fix events caching test #1138

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3901c22
[SYCL] Fix events caching test
againull Aug 8, 2022
8694aa3
Add a comment
againull Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion SYCL/Plugin/level_zero_events_caching.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@
// RUN: env SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=0 ZE_DEBUG=4 %GPU_RUN_PLACEHOLDER %t.out 2>&1 | FileCheck --check-prefixes=CACHING-ENABLED %s
// RUN: env SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=0 SYCL_PI_LEVEL_ZERO_DISABLE_EVENTS_CACHING=1 ZE_DEBUG=4 %GPU_RUN_PLACEHOLDER %t.out 2>&1 | FileCheck --check-prefixes=CACHING-DISABLED %s

// CACHING-ENABLED: zeEventCreate = 1
// With events caching we should be reusing them and 9 should be enough.
// Might require more than one if previous one hasn't been released by the time
// we need a new one.

// CACHING-ENABLED: zeEventCreate = {{[1-9]}}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// CACHING-ENABLED: zeEventCreate = {{[1-9]}}
// With events caching we should be reusing them and 9 should be enough.
// Might require more than one if previous one has already been released
// by the time we need a new one.
// CACHING-ENABLED: zeEventCreate = {{[1-9]}}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment, thanks.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, I confused released/destroyed. Your update looks fine.

// CACHING-DISABLED: zeEventCreate = 256

// Check event caching modes in the L0 plugin.
Expand Down