Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] disable esimd_preemption on dg2 #1159

Merged
merged 1 commit into from
Oct 13, 2022
Merged

[SYCL] disable esimd_preemption on dg2 #1159

merged 1 commit into from
Oct 13, 2022

Conversation

myler
Copy link

@myler myler commented Aug 18, 2022 •
edited
Loading

Mid-thread preemption is not supported on DG2. See IGC-3240 for more info.

@myler myler requested a review from a team as a code owner August 18, 2022 02:51
@myler
Copy link
Author

myler commented Aug 18, 2022

Unrelated failure:

[2022-08-18T03:11:26.305Z] Failed Tests (1):
[2022-08-18T03:11:26.305Z]   SYCL :: DeprecatedFeatures/event_creation_opencl.cpp
[2022-08-18T03:11:26.305Z]

It is failed due to #intel/6570

@myler myler changed the title disable esimd_preemption on dg2 [SYCL] disable esimd_preemption on dg2 Sep 5, 2022
@myler
Copy link
Author

myler commented Sep 5, 2022

Failures are unrelated to this PR.
Hi @v-klochkov
According to the https://github.com/intel/llvm-test-suite/blob/intel/CONTRIBUTING.md#merge, need maintainer to merge the PR. Could you help me on this?

@myler
Copy link
Author

myler commented Oct 13, 2022

Hi @steffenlarsen
According to the https://github.com/intel/llvm-test-suite/blob/intel/CONTRIBUTING.md#merge, need maintainer to merge the PR.
May I ask you to help me to merge this PR?

@steffenlarsen
Copy link

Hi @steffenlarsen According to the https://github.com/intel/llvm-test-suite/blob/intel/CONTRIBUTING.md#merge, need maintainer to merge the PR. May I ask you to help me to merge this PR?

Absolutely! We just need the CI to finish.

@steffenlarsen
Copy link

Windows failure seems to be in CI infrastructure. Other failures are unrelated and are fixed in recent changes to intel/llvm.

@steffenlarsen steffenlarsen merged commit a5a41f4 into intel:intel Oct 13, 2022
myler added a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
@myler
[SYCL] disable esimd_preemption on dg2 (intel#1159)
59ac2fb 
disable esimd_preemption on dg2
myler added a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
@myler
Merge pull request intel#1310 from myler/CMPLRTST-17506-xmain
905ae56 
[SYCL] disable esimd_preemption on dg2 (intel#1159)
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@myler
[SYCL] disable esimd_preemption on dg2 (intel/llvm-test-suite#1159)
39c846a 
disable esimd_preemption on dg2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myler @steffenlarsen @v-klochkov