[SYCL][ABI-break] Remove legacy get member function from event #6570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SYCL 1.2.1 had a get member function on select classes for getting the underlying OpenCL object. With SYCL 2020 those were removed and replaced with a more general API. This commit removes the get member function from the sycl::event class. Signed-off-by: Larsen, Steffen <[email protected]>
v-klochkov
reviewed
Aug 15, 2022
Signed-off-by: Larsen, Steffen <[email protected]>
Yes, that was should absolutely be removed! I don't even know how I forgot to do that. |
v-klochkov
approved these changes
Aug 16, 2022
|
Failures unrelated: |
steffenlarsen
added a commit
to steffenlarsen/llvm-test-suite
that referenced
this pull request
Aug 18, 2022
intel/llvm#6570 removed the OpenCL interop get member function from sycl::event. SYCL/DeprecatedFeatures/event_creation_opencl.cpp used the removed feature and should as such be removed. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
added a commit
to intel/llvm-test-suite
that referenced
this pull request
Aug 18, 2022
intel/llvm#6570 removed the OpenCL interop get member function from sycl::event. SYCL/DeprecatedFeatures/event_creation_opencl.cpp used the removed feature and should as such be removed. Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…llvm-test-suite#1161) intel#6570 removed the OpenCL interop get member function from sycl::event. SYCL/DeprecatedFeatures/event_creation_opencl.cpp used the removed feature and should as such be removed. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SYCL 1.2.1 had a get member function on select classes for getting the underlying OpenCL object. With SYCL 2020 those were removed and replaced with a more general API. This commit removes the get member function from the sycl::event class.