[SYCL] Add bfloat16 'hello world' host test. #1189

kbobrovs · 2022-08-30T22:26:52Z

Test for intel/llvm#6675.
Signed-off-by: Konstantin S Bobrovsky [email protected]

Signed-off-by: Konstantin S Bobrovsky <[email protected]>

kbobrovs · 2022-08-31T05:20:21Z

/verify with intel/llvm#6675

kbobrovs · 2022-08-31T05:23:04Z

/verify with intel/llvm#6675

kbobrovs · 2022-08-31T05:48:04Z

/verify with intel/llvm#6675

kbobrovs · 2022-08-31T07:22:54Z

/verify with intel/llvm#6675

AlexeySachkov · 2022-08-31T12:27:35Z

SYCL/BFloat16/bfloat_hw.cpp

@@ -0,0 +1,50 @@
+// RUN: %clangxx -fsycl %s -o %t.out
+// RUN: %HOST_RUN_PLACEHOLDER %t.out


Suggested change

// RUN: %HOST_RUN_PLACEHOLDER %t.out

Host device is going to be removed soon. Moreover, you don't even use any devices in the test, so no need for any special placeholders

Maybe add a single_task to verify it works on device as well then?

Should I just say
// RUN: %t.out
?

Maybe add a single_task to verify it works on device as well then?

Yes, good idea. But this is E2E regression test for particular problem I found on host. Test coverage can be improved in separate patches, I believe.

SYCL/BFloat16/bfloat_hw.cpp

Co-authored-by: aelovikov-intel <[email protected]>

SYCL/BFloat16/bfloat_hw.cpp

kbobrovs · 2022-08-31T19:49:01Z

/verify with intel/llvm#6675

asudarsa · 2022-08-31T22:01:38Z

Adding @rdeodhar who is working on moving bfloat16 support out of experimental. Rajiv,
can you please take a look? Thanks

rdeodhar · 2022-08-31T22:24:06Z

We're moving towards removing the to_float and from_float public interfaces. Also, raw is being removed. This will check the conversions:

bfloat16 bf{3.140625f};
if (bf.float() == 3.140625f) then "pass"

kbobrovs · 2022-09-01T06:12:43Z

We're moving towards removing the to_float and from_float public interfaces. Also, raw is being removed. This will check the conversions:
bfloat16 bf{3.140625f};
if (bf.float() == 3.140625f) then "pass"

I use neither to_float nor from_float - ?

kbobrovs · 2022-09-01T06:16:12Z

... but I use raw(). OK will try to get away only with constructors and bitcasts

kbobrovs · 2022-09-01T21:01:54Z

@rdeodhar, @aelovikov-intel, @AlexeySachkov - please review

kbobrovs · 2022-09-01T21:02:29Z

/verify with intel/llvm#6675

SYCL/BFloat16/bfloat_hw.cpp

aelovikov-intel · 2022-09-01T21:07:26Z

SYCL/BFloat16/bfloat_hw.cpp

@@ -0,0 +1,60 @@
+// RUN: %clangxx -fsycl %s -o %t.out
+// RUN: %t.out


I'm not sure if that is what we're supposed to do, but I honestly don't know.

Maybe someone else from @intel/llvm-reviewers-runtime know.

Seems fine to me.

Co-authored-by: aelovikov-intel <[email protected]>

SYCL/BFloat16/bfloat_hw.cpp

rdeodhar · 2022-09-01T21:19:24Z

Looks OK.

SYCL/BFloat16/bfloat_hw.cpp

kbobrovs · 2022-09-01T21:21:26Z

/verify with intel/llvm#6675

kbobrovs · 2022-09-02T02:09:06Z

Testing with intel/llvm#6675 has only known TGL-specific failures on Windows

[2022-09-01T22:56:01.536Z] SYCL :: AtomicRef/assignment_atomic64.cpp
[2022-09-01T22:56:01.536Z] SYCL :: AtomicRef/assignment_atomic64_generic.cpp
[2022-09-01T22:56:01.536Z] SYCL :: Basic/buffer/buffer.cpp
[2022-09-01T22:56:01.537Z] SYCL :: DeprecatedFeatures/SpecConsts1.2.1/specialization_constants.cpp
[2022-09-01T22:56:01.537Z] SYCL :: DeprecatedFeatures/SpecConsts1.2.1/specialization_constants_override.cpp
[2022-09-01T22:56:01.537Z] SYCL :: DeviceLib/built-ins/nan.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/aot_mixed.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/api/bin_and_cmp_ops_heavy.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/api/functional/ctors/ctor_converting_fp_extra.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/api/functional/ctors/ctor_load_acc_fp_extra.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/api/functional/ctors/ctor_load_usm_fp_extra.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/api/functional/functions/functions_select_2d_core.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/api/functional/functions/functions_select_2d_fp_extra.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/api/functional/operators/operator_decrement_and_increment_accuracy_fp_extra.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/api/functional/operators/operator_decrement_and_increment_fp_extra.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/api/replicate_smoke.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/api/saturation_smoke.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/api/simd_view_select_2d_fp.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/api/simd_view_select_2d_int.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/api/unary_ops_heavy.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/ext_math.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/matrix_transpose_glb.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/regression/dgetrf.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/regression/dgetrf_8x8.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/regression/dgetrf_ref.cpp
[2022-09-01T22:56:01.537Z] SYCL :: ESIMD/spec_const/spec_const_double.cpp
[2022-09-01T22:56:01.537Z] SYCL :: GroupAlgorithm/SYCL2020/sort.cpp
[2022-09-01T22:56:01.537Z] SYCL :: KernelParams/union_kernel_param.cpp
[2022-09-01T22:56:01.537Z] SYCL :: SpecConstants/2020/handler-api.cpp
[2022-09-01T22:56:01.537Z] SYCL :: SpecConstants/2020/kernel-bundle-api.cpp
[2022-09-01T22:56:01.537Z] SYCL :: SubGroup/barrier.cpp
[2022-09-01T22:56:01.537Z] SYCL :: SubGroup/broadcast_fp64.cpp
[2022-09-01T22:56:01.537Z] SYCL :: SubGroup/info.cpp
[2022-09-01T22:56:01.537Z] SYCL :: SubGroup/load_store.cpp
[2022-09-01T22:56:01.537Z] SYCL :: SubGroup/shuffle_fp64.cpp
[2022-09-01T22:56:01.537Z] SYCL :: USM/copy.cpp
[2022-09-01T22:56:01.537Z] SYCL :: USM/fill.cpp

kbobrovs · 2022-09-05T17:35:40Z

bfloat_hw.cpp passed everywhere

* [SYCL] Add bfloat16 'hello world' host test. Signed-off-by: Konstantin S Bobrovsky <[email protected]>

) * [SYCL] Add bfloat16 'hello world' host test. Signed-off-by: Konstantin S Bobrovsky <[email protected]>

[SYCL] Add bfloat16 'hello world' host test.

3650f3b

Signed-off-by: Konstantin S Bobrovsky <[email protected]>

kbobrovs requested a review from a team as a code owner August 30, 2022 22:26

kbobrovs mentioned this pull request Aug 30, 2022

[SYCL] Fix bfloat16::to_float() host implementation. intel/llvm#6675

Merged

Add missing return to function.

a27450b

clang-format

92c8e96

AlexeySachkov previously approved these changes Aug 31, 2022

View reviewed changes

aelovikov-intel reviewed Aug 31, 2022

View reviewed changes

SYCL/BFloat16/bfloat_hw.cpp Outdated Show resolved Hide resolved

kbobrovs dismissed AlexeySachkov’s stale review via b3e3072 August 31, 2022 19:36

Update SYCL/BFloat16/bfloat_hw.cpp

b3e3072

Co-authored-by: aelovikov-intel <[email protected]>

kbobrovs commented Aug 31, 2022

View reviewed changes

SYCL/BFloat16/bfloat_hw.cpp Outdated Show resolved Hide resolved

Update SYCL/BFloat16/bfloat_hw.cpp

b606499

kbobrovs requested review from aelovikov-intel and AlexeySachkov August 31, 2022 19:49

address review comments

d0b7357

aelovikov-intel reviewed Sep 1, 2022

View reviewed changes

Update SYCL/BFloat16/bfloat_hw.cpp

ff4502e

Co-authored-by: aelovikov-intel <[email protected]>

kbobrovs commented Sep 1, 2022

View reviewed changes

SYCL/BFloat16/bfloat_hw.cpp Outdated Show resolved Hide resolved

kbobrovs commented Sep 1, 2022

View reviewed changes

SYCL/BFloat16/bfloat_hw.cpp Outdated Show resolved Hide resolved

kbobrovs commented Sep 1, 2022

View reviewed changes

SYCL/BFloat16/bfloat_hw.cpp Outdated Show resolved Hide resolved

kbobrovs commented Sep 1, 2022

View reviewed changes

SYCL/BFloat16/bfloat_hw.cpp Show resolved Hide resolved

Apply suggestions from code review

4db1c0b

kbobrovs commented Sep 1, 2022

View reviewed changes

SYCL/BFloat16/bfloat_hw.cpp Outdated Show resolved Hide resolved

Update SYCL/BFloat16/bfloat_hw.cpp

f5751bd

kbobrovs requested review from againull and aelovikov-intel September 2, 2022 02:09

AlexeySachkov approved these changes Sep 2, 2022

View reviewed changes

Merge remote-tracking branch 'intel/intel' into bfloat16_fix

7fa1850

kbobrovs merged commit 2fef19b into intel:intel Sep 5, 2022

myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023

[SYCL] Add bfloat16 'hello world' host test. (intel#1189)

e25c943

* [SYCL] Add bfloat16 'hello world' host test. Signed-off-by: Konstantin S Bobrovsky <[email protected]>

aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023

[SYCL] Add bfloat16 'hello world' host test. (intel/llvm-test-suite#1189

f41049e

) * [SYCL] Add bfloat16 'hello world' host test. Signed-off-by: Konstantin S Bobrovsky <[email protected]>

		@@ -0,0 +1,50 @@
		// RUN: %clangxx -fsycl %s -o %t.out
		// RUN: %HOST_RUN_PLACEHOLDER %t.out

		@@ -0,0 +1,60 @@
		// RUN: %clangxx -fsycl %s -o %t.out
		// RUN: %t.out

[SYCL] Add bfloat16 'hello world' host test. #1189

[SYCL] Add bfloat16 'hello world' host test. #1189

Uh oh!

Conversation

kbobrovs commented Aug 30, 2022

Uh oh!

kbobrovs commented Aug 31, 2022

Uh oh!

kbobrovs commented Aug 31, 2022

Uh oh!

kbobrovs commented Aug 31, 2022

Uh oh!

kbobrovs commented Aug 31, 2022

Uh oh!

AlexeySachkov Aug 31, 2022

Choose a reason for hiding this comment

Uh oh!

aelovikov-intel Aug 31, 2022

Choose a reason for hiding this comment

Uh oh!

kbobrovs Aug 31, 2022

Choose a reason for hiding this comment

Uh oh!

kbobrovs Aug 31, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kbobrovs commented Aug 31, 2022

Uh oh!

asudarsa commented Aug 31, 2022

Uh oh!

rdeodhar commented Aug 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kbobrovs commented Sep 1, 2022

Uh oh!

kbobrovs commented Sep 1, 2022

Uh oh!

kbobrovs commented Sep 1, 2022

Uh oh!

kbobrovs commented Sep 1, 2022

Uh oh!

Uh oh!

aelovikov-intel Sep 1, 2022

Choose a reason for hiding this comment

Uh oh!

againull Sep 1, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdeodhar commented Sep 1, 2022

Uh oh!

Uh oh!

kbobrovs commented Sep 1, 2022

Uh oh!

kbobrovs commented Sep 2, 2022

Uh oh!

kbobrovs commented Sep 5, 2022

Uh oh!

Uh oh!

rdeodhar commented Aug 31, 2022 •

edited

Loading