[SYCL] Fix bfloat16::to_float() host implementation. #6675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
|
@v-klochkov, FYI |
|
@cperkinsintel, @intel/llvm-reviewers-runtime - please take a look at this small PR |
MrSidims
previously approved these changes
Aug 31, 2022
| Success &= check_bf16_to_float( | ||
| 0, bitsToFloatConv(std::string("00000000000000000000000000000000"))); | ||
| Success &= check_bf16_to_float( | ||
| 1, bitsToFloatConv(std::string("01000111100000000000000000000000"))); |
There was a problem hiding this comment.
Oh, that was a huge mistake, sorry about that.
There was a problem hiding this comment.
bugs happen, no problem )
Comment on lines
66
to
72
| union { | ||
| uint32_t bits; | ||
| float res; | ||
| } val; | ||
| val.bits = a; | ||
| val.bits <<= 16; | ||
| return val.res; |
There was a problem hiding this comment.
We seem to have sycl::bit_cast, can we use it here? If not, then a comment is necessary to explain why.
There was a problem hiding this comment.
good point, will fix
|
@aelovikov-intel, @cperkinsintel - please review |
|
@aelovikov-intel, @cperkinsintel, ping |
aelovikov-intel
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New E2E test: intel/llvm-test-suite#1189
Signed-off-by: Konstantin S Bobrovsky [email protected]