This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Fix USM/copy.cpp for double #1244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have a local machine that can reproduce the failure, so will have to use pre-commit testing to see if it actually works. |
romanovvlad
reviewed
Sep 11, 2022
| @@ -71,6 +71,10 @@ template <typename T> void test(queue q, T val, T *src, T *dst, bool dev_dst) { | |||
| } | |||
|
|
|||
| template <typename T> void runTests(queue q, T val, alloc kind1, alloc kind2) { | |||
| if ((std::is_same_v<T, double> || std::is_same_v<T, test_struct>)&&!q | |||
There was a problem hiding this comment.
Maybe we can just remove double from the test_struct or have two structs - with and without double.
There was a problem hiding this comment.
I have applied this suggestion in #1242
|
Closing in favor of #1242. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.