Update more tests to account for optionality of double type #1242
Conversation
AlexeySachkov
requested review from
aelovikov-intel
and removed request for
a team
| @@ -12,27 +12,27 @@ union TestUnion { | |||
| public: | |||
| int myint; | |||
| char mychar; | |||
| double mydouble; | |||
| float myfloat; | |||
There was a problem hiding this comment.
I'm fixing this file in https://github.com/intel/llvm-test-suite/pull/1246/files#diff-9f0383b6a7accb5ff82cb27e7a3b7119a9d065378c683962c9d1ebdd5e52c94f
Note that I'm updating FP literals as well.
There was a problem hiding this comment.
If any work on this PR is planned, I'd prefer you to exclude this file from it. Otherwise, if it's ready, we can submit and I'll update literals only in my PR.
| @@ -40,7 +37,7 @@ int main() { | |||
| auto Kernel = KB.get_kernel(KernelID); | |||
| range<2> GlobalRange{50, 40}; | |||
|
|
|||
| buffer<double, 2> ABuf{GlobalRange}, BBuf{GlobalRange}, CBuf{GlobalRange}; | |||
| buffer<float, 2> ABuf{GlobalRange}, BBuf{GlobalRange}, CBuf{GlobalRange}; | |||
There was a problem hiding this comment.
I'm also touching it in #1246, but I prefer your change. I'll exclude the file from my PR.
There was a problem hiding this comment.
LGTM, but @kbobrovs might have another opinion regarding skipping tests.
| @@ -27,12 +27,11 @@ struct test_struct { | |||
| long long d; | |||
| half e; | |||
| float f; | |||
| double g; | |||
There was a problem hiding this comment.
Could we have another struct with the double and give it the same treatment as just double?
There was a problem hiding this comment.
I think this can be addressed post-commit in another PR to fix the currently failing tests in CI asap.
@intel/llvm-gatekeepers would you agree with that? If so, please merge it in - the tests modified here are passing in pre-commit CI and the failures are on other tests and thus unrelated.
No description provided.