[SYCL] Check for aspect::fp64 in ESIMD/api/*ops_heavy.cpp #1248
Conversation
| if (dev.has(aspect::fp64)) | ||
| passed &= test<double, half, 7, BinOp, VSf, IDf>(arith_ops, q); |
There was a problem hiding this comment.
I think, this code should check for both fp64 and fp16
| passed &= test<half, char, 1, BinOp, verify_n, IDf>(div_op, q, 1); | ||
| passed &= test<half, unsigned int, 32, BinOp, VSf, IDf>(div_op, q, 1); |
There was a problem hiding this comment.
Would you please add check for fp16?
There was a problem hiding this comment.
I'd rather do it in a different PR. Fp64 is way more urgent because our CI is broken.
|
The tests modified in this PR start to pass in the CI (no mention of them in the failed tasks) hence the failures are unrelated. FP16 aspect isn't as urgent and should be addressed in a different PR. Can anybody approve and merge this? |
|
@intel/llvm-gatekeepers we've agreed offline to proceed with this approach in the short term at least. The tests updated by this PR are passing in pre-commit CI (and thus other failures are unrelated). Please merge this in. |
add missed test xml.
No description provided.